Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9bfb2f0 authored by Chanwoo Choi's avatar Chanwoo Choi Committed by Dmitry Torokhov
Browse files

Input: stmfts - fix setting ABS_MT_POSITION_* maximum size



The commit 78bcac7b ("Input: add support for the STMicroelectronics
FingerTip touchscreen) used the 'touchscreen_parse_properties()' helper
function in order to get the value of common properties.

But, commit 78bcac7b didn't set the capability of ABS_MT_POSITION_*
before calling touchscreen_parse_properties(). In result, the max_x and
max_y of 'struct touchscreen_properties' were not set.

Fixes: 78bcac7b ("Input: add support for the STMicroelectronics FingerTip touchscreen")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent cf5dd489
Loading
Loading
Loading
Loading
+2 −4
Original line number Original line Diff line number Diff line
@@ -663,12 +663,10 @@ static int stmfts_probe(struct i2c_client *client,
	sdata->input->open = stmfts_input_open;
	sdata->input->open = stmfts_input_open;
	sdata->input->close = stmfts_input_close;
	sdata->input->close = stmfts_input_close;


	input_set_capability(sdata->input, EV_ABS, ABS_MT_POSITION_X);
	input_set_capability(sdata->input, EV_ABS, ABS_MT_POSITION_Y);
	touchscreen_parse_properties(sdata->input, true, &sdata->prop);
	touchscreen_parse_properties(sdata->input, true, &sdata->prop);


	input_set_abs_params(sdata->input, ABS_MT_POSITION_X, 0,
						sdata->prop.max_x, 0, 0);
	input_set_abs_params(sdata->input, ABS_MT_POSITION_Y, 0,
						sdata->prop.max_y, 0, 0);
	input_set_abs_params(sdata->input, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0);
	input_set_abs_params(sdata->input, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0);
	input_set_abs_params(sdata->input, ABS_MT_TOUCH_MINOR, 0, 255, 0, 0);
	input_set_abs_params(sdata->input, ABS_MT_TOUCH_MINOR, 0, 255, 0, 0);
	input_set_abs_params(sdata->input, ABS_MT_ORIENTATION, 0, 255, 0, 0);
	input_set_abs_params(sdata->input, ABS_MT_ORIENTATION, 0, 255, 0, 0);