Commit c89876dd authored Jun 30, 2017 by Gustavo A. R. Silva Committed by Greg Kroah-Hartman Jul 17, 2017

w1: omap-hdq: fix error return code in omap_hdq_probe()



platform_get_irq() returns an error code, but the omap_hdq
driver ignores it and always returns -ENXIO. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error.

Print error message and propagate the return value of
platform_get_irq on failure.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent cc84b824

drivers/w1/masters/omap_hdq.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -704,7 +704,8 @@ static int omap_hdq_probe(struct platform_device *pdev)

		irq = platform_get_irq(pdev, 0);
		if (irq < 0) {
		ret = -ENXIO;
		dev_dbg(&pdev->dev, "Failed to get IRQ: %d\n", irq);
		ret = irq;
		goto err_irq;
		}