Commit c790b0ad authored Jun 20, 2013 by Oleg Nesterov Committed by Ingo Molnar Jun 20, 2013

hw_breakpoint: Use cpu_possible_mask in {reserve,release}_bp_slot()



fetch_bp_busy_slots() and toggle_bp_slot() use
for_each_online_cpu(), this is obviously wrong wrt cpu_up() or
cpu_down(), we can over/under account the per-cpu numbers.

For example:

	# echo 0 >> /sys/devices/system/cpu/cpu1/online
	# perf record -e mem:0x10 -p 1 &
	# echo 1 >> /sys/devices/system/cpu/cpu1/online
	# perf record -e mem:0x10,mem:0x10,mem:0x10,mem:0x10 -C1 -a &
	# taskset -p 0x2 1

triggers the same WARN_ONCE("Can't find any breakpoint slot") in
arch_install_hw_breakpoint().

Reported-by: Vince Weaver <vincent.weaver@maine.edu>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/20130620155009.GA6327@redhat.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 8b4d801b

kernel/events/hw_breakpoint.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -149,7 +149,7 @@ fetch_bp_busy_slots(struct bp_busy_slots slots, struct perf_event bp,
	return;		return;
	}		}

	for_each_online_cpu(cpu) {		for_each_possible_cpu(cpu) {
	unsigned int nr;		unsigned int nr;

	nr = per_cpu(nr_cpu_bp_pinned[type], cpu);		nr = per_cpu(nr_cpu_bp_pinned[type], cpu);
	@@ -235,7 +235,7 @@ toggle_bp_slot(struct perf_event *bp, bool enable, enum bp_type_idx type,
	if (cpu >= 0) {		if (cpu >= 0) {
	toggle_bp_task_slot(bp, cpu, enable, type, weight);		toggle_bp_task_slot(bp, cpu, enable, type, weight);
	} else {		} else {
	for_each_online_cpu(cpu)		for_each_possible_cpu(cpu)
	toggle_bp_task_slot(bp, cpu, enable, type, weight);		toggle_bp_task_slot(bp, cpu, enable, type, weight);
	}		}