Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c737bcf9 authored by Benjamin Tissoires's avatar Benjamin Tissoires Committed by Jiri Kosina
Browse files

HID: i2c-hid: i2c_hid_get_report may fail 



If i2c_hid_get_report fails, exit i2c_hid_init_report.
The printk log is already called by i2c_hid_get_report, so no need
to add some more printks.

Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@gmail.com>
Reviewed-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 134ebfd8

drivers/hid/i2c-hid/i2c-hid.c

+3 −2
Original line number Diff line number Diff line
@@ -399,9 +399,10 @@ static void i2c_hid_init_report(struct hid_report *report, u8 *buffer, 
	unsigned int size, ret_size;



	size = i2c_hid_get_report_length(report);

	i2c_hid_get_report(client,

	if (i2c_hid_get_report(client,

			report->type == HID_FEATURE_REPORT ? 0x03 : 0x01,

			report->id, buffer, size);

			report->id, buffer, size))

		return;



	i2c_hid_dbg(ihid, "report (len=%d): %*ph\n", size, size, ihid->inbuf);