Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2f14ba7 authored by Markus Elfring's avatar Markus Elfring Committed by Takashi Iwai
Browse files

ALSA: compress: Use memdup_user() rather than duplicating its implementation 



Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarVinod Koul <vinod.koul@intel.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 1bc00f32

sound/core/compress_offload.c

+3 −7
Original line number Diff line number Diff line
@@ -553,13 +553,9 @@ snd_compr_set_params(struct snd_compr_stream *stream, unsigned long arg) 
		 * we should allow parameter change only when stream has been

		 * opened not in other cases

		 */

		params = kmalloc(sizeof(*params), GFP_KERNEL);

		if (!params)

			return -ENOMEM;

		if (copy_from_user(params, (void __user *)arg, sizeof(*params))) {

			retval = -EFAULT;

			goto out;

		}

		params = memdup_user((void __user *)arg, sizeof(*params));

		if (IS_ERR(params))

			return PTR_ERR(params);



		retval = snd_compress_check_input(params);

		if (retval)