Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c1db7a26 authored by Daniel Borkmann's avatar Daniel Borkmann Committed by David S. Miller
Browse files

net: sctp: sctp_ulpq: remove 'malloced' struct member 



The structure sctp_ulpq is embedded into sctp_association and never
separately allocated, also ulpq->malloced is always 0, so that
kfree() is never called. Therefore, remove this code.

Signed-off-by: default avatarDaniel Borkmann <dborkman@redhat.com>
Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 50181c07

include/net/sctp/ulpqueue.h

+0 −1
Original line number Diff line number Diff line
@@ -49,7 +49,6 @@ 


/* A structure to carry information to the ULP (e.g. Sockets API) */

struct sctp_ulpq {

	char malloced;

	char pd_mode;

	struct sctp_association *asoc;

	struct sk_buff_head reasm;

net/sctp/ulpqueue.c

+0 −3
Original line number Diff line number Diff line
@@ -68,7 +68,6 @@ struct sctp_ulpq *sctp_ulpq_init(struct sctp_ulpq *ulpq, 
	skb_queue_head_init(&ulpq->reasm);

	skb_queue_head_init(&ulpq->lobby);

	ulpq->pd_mode  = 0;

	ulpq->malloced = 0;



	return ulpq;

}
@@ -96,8 +95,6 @@ void sctp_ulpq_flush(struct sctp_ulpq *ulpq) 
void sctp_ulpq_free(struct sctp_ulpq *ulpq)

{

	sctp_ulpq_flush(ulpq);

	if (ulpq->malloced)

		kfree(ulpq);

}



/* Process an incoming DATA chunk.  */