Commit b9322252 authored May 11, 2012 by Michael Grzeschik Committed by Greg Kroah-Hartman May 11, 2012

usb: chipidea: isr_reset_handler fix missing locking



Move spin_lock under the done label, so the
lock will also be pulled in the error paths.

Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
[rebased on top of the patchset]
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 551a8ac6

drivers/usb/chipidea/udc.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -645,9 +645,9 @@ __acquires(udc->lock)
	if (udc->status == NULL)		if (udc->status == NULL)
	retval = -ENOMEM;		retval = -ENOMEM;

			done:
	spin_lock(&udc->lock);		spin_lock(&udc->lock);

	done:
	if (retval)		if (retval)
	dev_err(udc->dev, "error: %i\n", retval);		dev_err(udc->dev, "error: %i\n", retval);
	}		}