Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b77a5372 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Darren Hart (VMware)
Browse files

platform/x86: fujitsu-laptop: add NULL check on devm_kzalloc() return value 



Check return value from call to devm_kzalloc()
in order to prevent a NULL pointer dereference.

This issue was detected using Coccinelle and the following semantic patch:

@@
expression x;
identifier fld;
@@

* x = devm_kzalloc(...);
  ... when != x == NULL
  x->fld

Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: default avatarJonathan Woithe <jwoithe@just42.net>
Signed-off-by: default avatarDarren Hart (VMware) <dvhart@infradead.org>
parent 4edfc540

drivers/platform/x86/fujitsu-laptop.c

+12 −0
Original line number Diff line number Diff line
@@ -695,6 +695,9 @@ static int acpi_fujitsu_laptop_leds_register(struct acpi_device *device) 
	if (call_fext_func(device,

			   FUNC_LEDS, 0x0, 0x0, 0x0) & LOGOLAMP_POWERON) {

		led = devm_kzalloc(&device->dev, sizeof(*led), GFP_KERNEL);

		if (!led)

			return -ENOMEM;



		led->name = "fujitsu::logolamp";

		led->brightness_set_blocking = logolamp_set;

		led->brightness_get = logolamp_get;
@@ -707,6 +710,9 @@ static int acpi_fujitsu_laptop_leds_register(struct acpi_device *device) 
			    FUNC_LEDS, 0x0, 0x0, 0x0) & KEYBOARD_LAMPS) &&

	    (call_fext_func(device, FUNC_BUTTONS, 0x0, 0x0, 0x0) == 0x0)) {

		led = devm_kzalloc(&device->dev, sizeof(*led), GFP_KERNEL);

		if (!led)

			return -ENOMEM;



		led->name = "fujitsu::kblamps";

		led->brightness_set_blocking = kblamps_set;

		led->brightness_get = kblamps_get;
@@ -723,6 +729,9 @@ static int acpi_fujitsu_laptop_leds_register(struct acpi_device *device) 
	 */

	if (call_fext_func(device, FUNC_BUTTONS, 0x0, 0x0, 0x0) & BIT(24)) {

		led = devm_kzalloc(&device->dev, sizeof(*led), GFP_KERNEL);

		if (!led)

			return -ENOMEM;



		led->name = "fujitsu::radio_led";

		led->brightness_set_blocking = radio_led_set;

		led->brightness_get = radio_led_get;
@@ -741,6 +750,9 @@ static int acpi_fujitsu_laptop_leds_register(struct acpi_device *device) 
	    (call_fext_func(device,

			    FUNC_LEDS, 0x2, ECO_LED, 0x0) != UNSUPPORTED_CMD)) {

		led = devm_kzalloc(&device->dev, sizeof(*led), GFP_KERNEL);

		if (!led)

			return -ENOMEM;



		led->name = "fujitsu::eco_led";

		led->brightness_set_blocking = eco_led_set;

		led->brightness_get = eco_led_get;