Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6a930fa authored by Jingju Hou's avatar Jingju Hou Committed by David S. Miller
Browse files

net: phy: marvell: clear wol event before setting it 



If WOL event happened once, the LED[2] interrupt pin will not be
cleared unless we read the CSISR register. If interrupts are in use,
the normal interrupt handling will clear the WOL event. Let's clear the
WOL event before enabling it if !phy_interrupt_is_valid().

Signed-off-by: default avatarJingju Hou <Jingju.Hou@synaptics.com>
Signed-off-by: default avatarJisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 77621f02

drivers/net/phy/marvell.c

+9 −0
Original line number Diff line number Diff line
@@ -1393,6 +1393,15 @@ static int m88e1318_set_wol(struct phy_device *phydev, 
		if (err < 0)

			goto error;



		/* If WOL event happened once, the LED[2] interrupt pin

		 * will not be cleared unless we reading the interrupt status

		 * register. If interrupts are in use, the normal interrupt

		 * handling will clear the WOL event. Clear the WOL event

		 * before enabling it if !phy_interrupt_is_valid()

		 */

		if (!phy_interrupt_is_valid(phydev))

			phy_read(phydev, MII_M1011_IEVENT);



		/* Enable the WOL interrupt */

		err = __phy_modify(phydev, MII_88E1318S_PHY_CSIER, 0,

				   MII_88E1318S_PHY_CSIER_WOL_EIE);