Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2d3907c authored by Saeed Mahameed's avatar Saeed Mahameed
Browse files

net/mlx5: Eliminate query xsrq dead code 



1. This function is not used anywhere in mlx5 driver
2. It has a memcpy statement that makes no sense and produces build
warning with gcc8

drivers/net/ethernet/mellanox/mlx5/core/transobj.c: In function 'mlx5_core_query_xsrq':
drivers/net/ethernet/mellanox/mlx5/core/transobj.c:347:3: error: 'memcpy' source argument is the same as destination [-Werror=restrict]

Fixes: 01949d01 ("net/mlx5_core: Enable XRCs and SRQs when using ISSI > 0")
Reported-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 7b2117bb

drivers/net/ethernet/mellanox/mlx5/core/transobj.c

+0 −21
Original line number Diff line number Diff line
@@ -354,27 +354,6 @@ int mlx5_core_destroy_xsrq(struct mlx5_core_dev *dev, u32 xsrqn) 
	return mlx5_cmd_exec(dev, in, sizeof(in), out, sizeof(out));

}



int mlx5_core_query_xsrq(struct mlx5_core_dev *dev, u32 xsrqn, u32 *out)

{

	u32 in[MLX5_ST_SZ_DW(query_xrc_srq_in)] = {0};

	void *srqc;

	void *xrc_srqc;

	int err;



	MLX5_SET(query_xrc_srq_in, in, opcode,   MLX5_CMD_OP_QUERY_XRC_SRQ);

	MLX5_SET(query_xrc_srq_in, in, xrc_srqn, xsrqn);

	err = mlx5_cmd_exec(dev, in, sizeof(in), out,

			    MLX5_ST_SZ_BYTES(query_xrc_srq_out));

	if (!err) {

		xrc_srqc = MLX5_ADDR_OF(query_xrc_srq_out, out,

					xrc_srq_context_entry);

		srqc = MLX5_ADDR_OF(query_srq_out, out, srq_context_entry);

		memcpy(srqc, xrc_srqc, MLX5_ST_SZ_BYTES(srqc));

	}



	return err;

}



int mlx5_core_arm_xsrq(struct mlx5_core_dev *dev, u32 xsrqn, u16 lwm)

{

	u32 in[MLX5_ST_SZ_DW(arm_xrc_srq_in)]   = {0};

include/linux/mlx5/transobj.h

+0 −1
Original line number Diff line number Diff line
@@ -67,7 +67,6 @@ int mlx5_core_arm_rmp(struct mlx5_core_dev *dev, u32 rmpn, u16 lwm); 
int mlx5_core_create_xsrq(struct mlx5_core_dev *dev, u32 *in, int inlen,

			  u32 *rmpn);

int mlx5_core_destroy_xsrq(struct mlx5_core_dev *dev, u32 rmpn);

int mlx5_core_query_xsrq(struct mlx5_core_dev *dev, u32 rmpn, u32 *out);

int mlx5_core_arm_xsrq(struct mlx5_core_dev *dev, u32 rmpn, u16 lwm);



int mlx5_core_create_rqt(struct mlx5_core_dev *dev, u32 *in, int inlen,