Commit b206ed04 authored Jun 06, 2008 by Lennert Buytenhek Committed by Lennert Buytenhek Jun 22, 2008

[ARM] Orion: remove error printks in ->map_irq() implementations



If all PCI devices are working as expected, the error printks in the
various implementations of ->map_irq() doesn't really provide any
useful info.  And if something is not working as expected, turning
on pci=debug gives you more useful information than the printk calls
in ->map_irq(), since the former also tells you which devices _did_
get IRQs successfully assigned.  Therefore, delete these printks
entirely.

Spotted by Russell King.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Acked-by: Russell King <linux@arm.linux.org.uk>

parent 19cfd5c0

arch/arm/mach-orion5x/dns323-setup.c

+0 −2

Original line number	Original line	Diff line number	Diff line
	@@ -53,8 +53,6 @@ static int __init dns323_pci_map_irq(struct pci_dev *dev, u8 slot, u8 pin)
	if (irq != -1)		if (irq != -1)
	return irq;		return irq;

	pr_err("%s: requested mapping for unknown device\n", __func__);

	return -1;		return -1;
	}		}

arch/arm/mach-orion5x/kurobox_pro-setup.c

+0 −2

Original line number	Original line	Diff line number	Diff line
	@@ -131,8 +131,6 @@ static int __init kurobox_pro_pci_map_irq(struct pci_dev *dev, u8 slot, u8 pin)
	/*		/*
	* PCI isn't used on the Kuro		* PCI isn't used on the Kuro
	*/		*/
	printk(KERN_ERR "kurobox_pro_pci_map_irq failed, unknown bus\n");

	return -1;		return -1;
	}		}