Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1baae89 authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf hists browser: Skip scripting when perf.data file not available 



The script and data-switch context menu are only meaningful when it
deals with a data file.  So add a check so that it cannot be shown when
perf-top is run.

Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1453555902-18401-4-git-send-email-namhyung@kernel.org


[ Use goto skip_scripting instead of two is_report_browser() tests ]
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent c053a150

tools/perf/ui/browsers/hists.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -2303,6 +2303,9 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, 
					     &options[nr_options],

					     &options[nr_options],

					     socked_id);

					     socked_id);

		/* perf script support */

		/* perf script support */

		if (!is_report_browser(hbt))

			goto skip_scripting;



		if (browser->he_selection) {

		if (browser->he_selection) {

			if (sort__has_thread && thread) {

			if (sort__has_thread && thread) {

				nr_options += add_script_opt(browser,

				nr_options += add_script_opt(browser,
@@ -2330,6 +2333,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events, 
					     &options[nr_options], NULL, NULL);

					     &options[nr_options], NULL, NULL);

		nr_options += add_switch_opt(browser, &actions[nr_options],

		nr_options += add_switch_opt(browser, &actions[nr_options],

					     &options[nr_options]);

					     &options[nr_options]);

skip_scripting:

		nr_options += add_exit_opt(browser, &actions[nr_options],

		nr_options += add_exit_opt(browser, &actions[nr_options],

					   &options[nr_options]);

					   &options[nr_options]);