Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa7bc7ef authored Jan 10, 2011 by Arnaldo Carvalho de Melo

perf tools: Emit clearer message for sys_perf_event_open ENOENT return



Improve sys_perf_event_open ENOENT return handling in top and record, just
like 5a3446bc does for stat.

Cc: David Ahern <daahern@cisco.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 5a3446bc

tools/perf/builtin-record.c

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -331,6 +331,9 @@ static void create_counter(struct perf_evsel *evsel, int cpu)
	else if (err == ENODEV && cpu_list) {		else if (err == ENODEV && cpu_list) {
	die("No such device - did you specify"		die("No such device - did you specify"
	" an out-of-range profile CPU?\n");		" an out-of-range profile CPU?\n");
			} else if (err == ENOENT) {
			die("%s event is not supported. ",
			event_name(evsel));
	} else if (err == EINVAL && sample_id_all_avail) {		} else if (err == EINVAL && sample_id_all_avail) {
	/*		/*
	* Old kernel, no attr->sample_id_type_all field		* Old kernel, no attr->sample_id_type_all field

tools/perf/builtin-top.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1247,6 +1247,8 @@ static void start_counter(int i, struct perf_evsel *evsel)
	die("Permission error - are you root?\n"		die("Permission error - are you root?\n"
	"\t Consider tweaking"		"\t Consider tweaking"
	" /proc/sys/kernel/perf_event_paranoid.\n");		" /proc/sys/kernel/perf_event_paranoid.\n");
			if (err == ENOENT)
			die("%s event is not supported. ", event_name(evsel));
	/*		/*
	* If it's cycles then fall back to hrtimer		* If it's cycles then fall back to hrtimer
	* based cpu-clock-tick sw counter, which		* based cpu-clock-tick sw counter, which