Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a987004f authored by Roel Kluin's avatar Roel Kluin Committed by Takashi Iwai
Browse files

sound: mpu401.c: Buffer overflow 



mpu_synth_info[m].name is a char[30], and the minimum length of the data
written by sprintf is 31 bytes including terminating null.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c45ec06c

sound/oss/mpu401.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1074,7 +1074,7 @@ int attach_mpu401(struct address_info *hw_config, struct module *owner) 
			sprintf(mpu_synth_info[m].name, "%s (MPU401)", hw_config->name);

			sprintf(mpu_synth_info[m].name, "%s (MPU401)", hw_config->name);

		else

		else

			sprintf(mpu_synth_info[m].name,

			sprintf(mpu_synth_info[m].name,

				"MPU-401 %d.%d%c Midi interface #%d",

				"MPU-401 %d.%d%c MIDI #%d",

				(int) (devc->version & 0xf0) >> 4,

				(int) (devc->version & 0xf0) >> 4,

				devc->version & 0x0f,

				devc->version & 0x0f,

				revision_char,

				revision_char,