Commit a8bc71d4 authored Jan 10, 2018 by Dan Carpenter Committed by Herbert Xu Jan 18, 2018

hwrng: exynos - Signedness bug in exynos_trng_do_read()



"val" needs to be signed for the error handling to work.

Fixes: 6cd225cc ("hwrng: exynos - add Samsung Exynos True RNG driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 4565da7c

drivers/char/hw_random/exynos-trng.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -55,7 +55,7 @@ static int exynos_trng_do_read(struct hwrng rng, void data, size_t max,
		bool wait)
		{
		struct exynos_trng_dev *trng;
		u32 val;
		int val;

		max = min_t(size_t, max, (EXYNOS_TRNG_FIFO_LEN * 4));