Commit a80e1053 authored Oct 03, 2013 by Prarit Bhargava Committed by Matthew Garrett Nov 20, 2013

x86, wmi fix modalias_show return values



I just fixed this same bug in arch/powerpc/kernel/vio.c and took a quick
look for other similar errors in the kernel.

modalias_show() should return an empty string on error, not errno.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>

parent ed12f295

drivers/platform/x86/wmi.c

+4 −2

Original line number	Original line	Diff line number	Diff line
	@@ -672,8 +672,10 @@ static ssize_t modalias_show(struct device dev, struct device_attribute attr,
	struct wmi_block *wblock;		struct wmi_block *wblock;

	wblock = dev_get_drvdata(dev);		wblock = dev_get_drvdata(dev);
	if (!wblock)		if (!wblock) {
	return -ENOMEM;		strcat(buf, "\n");
			return strlen(buf);
			}

	wmi_gtoa(wblock->gblock.guid, guid_string);		wmi_gtoa(wblock->gblock.guid, guid_string);