Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a734b4a2 authored Mar 31, 2015 by Denys Vlasenko Committed by Ingo Molnar Apr 01, 2015

x86/asm: Replace "MOVQ $imm, %reg" with MOVL



There is no reason to use MOVQ to load a non-negative immediate
constant value into a 64-bit register. MOVL does the same, since
the upper 32 bits are zero-extended by the CPU.

This makes the code a bit smaller, while leaving functionality
unchanged.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Will Drewry <wad@chromium.org>
Link: http://lkml.kernel.org/r/1427821211-25099-8-git-send-email-dvlasenk@redhat.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 36acef25

arch/x86/crypto/crc32c-pcl-intel-asm_64.S

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -178,7 +178,7 @@ continue_block:
	## 2a) PROCESS FULL BLOCKS:		## 2a) PROCESS FULL BLOCKS:
	################################################################		################################################################
	full_block:		full_block:
	movq $128,%rax		movl $128,%eax
	lea 12882(block_0), block_1		lea 12882(block_0), block_1
	lea 12883(block_0), block_2		lea 12883(block_0), block_2
	add $12881, block_0		add $12881, block_0

arch/x86/crypto/twofish-x86_64-asm_64.S

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -264,7 +264,7 @@ ENTRY(twofish_enc_blk)
	movq R1, 8(%rsi)		movq R1, 8(%rsi)

	popq R1		popq R1
	movq $1,%rax		movl $1,%eax
	ret		ret
	ENDPROC(twofish_enc_blk)		ENDPROC(twofish_enc_blk)

	@@ -316,6 +316,6 @@ ENTRY(twofish_dec_blk)
	movq R1, 8(%rsi)		movq R1, 8(%rsi)

	popq R1		popq R1
	movq $1,%rax		movl $1,%eax
	ret		ret
	ENDPROC(twofish_dec_blk)		ENDPROC(twofish_dec_blk)

arch/x86/kernel/relocate_kernel_64.S

+4 −4

Original line number	Original line	Diff line number	Diff line
	@@ -123,7 +123,7 @@ identity_mapped:
	* Set cr4 to a known state:		* Set cr4 to a known state:
	* - physical address extension enabled		* - physical address extension enabled
	*/		*/
	movq $X86_CR4_PAE, %rax		movl $X86_CR4_PAE, %eax
	movq %rax, %cr4		movq %rax, %cr4

	jmp 1f		jmp 1f
	@@ -246,17 +246,17 @@ swap_pages:
	movq %rsi, %rax		movq %rsi, %rax

	movq %r10, %rdi		movq %r10, %rdi
	movq $512, %rcx		movl $512, %ecx
	rep ; movsq		rep ; movsq

	movq %rax, %rdi		movq %rax, %rdi
	movq %rdx, %rsi		movq %rdx, %rsi
	movq $512, %rcx		movl $512, %ecx
	rep ; movsq		rep ; movsq

	movq %rdx, %rdi		movq %rdx, %rdi
	movq %r10, %rsi		movq %r10, %rsi
	movq $512, %rcx		movl $512, %ecx
	rep ; movsq		rep ; movsq

	lea PAGE_SIZE(%rax), %rsi		lea PAGE_SIZE(%rax), %rsi