Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a377f9e9 authored by Konstantin Shkolnyy's avatar Konstantin Shkolnyy Committed by Johan Hovold
Browse files

USB: serial: cp210x: fix hardware flow-control disable 



A bug in the CRTSCTS handling caused RTS to alternate between

CRTSCTS=0 => "RTS is transmit active signal" and
CRTSCTS=1 => "RTS is used for receive flow control"

instead of

CRTSCTS=0 => "RTS is statically active" and
CRTSCTS=1 => "RTS is used for receive flow control"

This only happened after first having enabled CRTSCTS.

Signed-off-by: default avatarKonstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
Fixes: 39a66b8d ("[PATCH] USB: CP2101 Add support for flow control")
Cc: stable <stable@vger.kernel.org>
[johan: reword commit message ]
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 8c34d82e

drivers/usb/serial/cp210x.c

+1 −2
Original line number Diff line number Diff line
@@ -967,8 +967,7 @@ static void cp210x_set_termios(struct tty_struct *tty, 
		} else {

			modem_ctl[0] &= ~0x7B;

			modem_ctl[0] |= 0x01;

			/* FIXME - OR here instead of assignment looks wrong */

			modem_ctl[4] |= 0x40;

			modem_ctl[4] = 0x40;

			dev_dbg(dev, "%s - flow control = NONE\n", __func__);

		}