Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1ff5b05 authored by Kan Liang's avatar Kan Liang Committed by Arnaldo Carvalho de Melo
Browse files

perf top: Remove lost events checking 



There would be some records lost in overwrite mode because of pausing
the ringbuffer. It has little impact for the accuracy of the snapshot
and could be tolerated by 'perf top'.

Remove the lost events checking.

Signed-off-by: default avatarKan Liang <kan.liang@intel.com>
Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1516310792-208685-16-git-send-email-kan.liang@intel.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 06cc1a47

tools/perf/builtin-top.c

+5 −3
Original line number Diff line number Diff line
@@ -283,8 +283,9 @@ static void perf_top__print_sym_table(struct perf_top *top) 


	printf("%-*.*s\n", win_width, win_width, graph_dotted_line);



	if (hists->stats.nr_lost_warned !=

	    hists->stats.nr_events[PERF_RECORD_LOST]) {

	if (!top->record_opts.overwrite &&

	    (hists->stats.nr_lost_warned !=

	    hists->stats.nr_events[PERF_RECORD_LOST])) {

		hists->stats.nr_lost_warned =

			      hists->stats.nr_events[PERF_RECORD_LOST];

		color_fprintf(stdout, PERF_COLOR_RED,
@@ -611,7 +612,8 @@ static void *display_thread_tui(void *arg) 


	perf_evlist__tui_browse_hists(top->evlist, help, &hbt,

				      top->min_percent,

				      &top->session->header.env, true);

				      &top->session->header.env,

				      !top->record_opts.overwrite);



	done = 1;

	return NULL;