Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1bbec72 authored by Phil Reid's avatar Phil Reid Committed by Sebastian Reichel
Browse files

power: supply: sbs-battery: remove incorrect le16_to_cpu calls 



i2c_smbus commands handle the correct byte order for smbus transactions
internally. This will currently result in incorrect operation on big
endian systems.

Signed-off-by: default avatarPhil Reid <preid@electromag.com.au>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
parent fc443138

drivers/power/supply/sbs-battery.c

+3 −4
Original line number Diff line number Diff line
@@ -199,7 +199,7 @@ static int sbs_read_word_data(struct i2c_client *client, u8 address) 
		return ret;

	}



	return le16_to_cpu(ret);

	return ret;

}



static int sbs_read_string_data(struct i2c_client *client, u8 address,
@@ -265,7 +265,7 @@ static int sbs_read_string_data(struct i2c_client *client, u8 address, 
	memcpy(values, block_buffer + 1, block_length);

	values[block_length] = '\0';



	return le16_to_cpu(ret);

	return ret;

}



static int sbs_write_word_data(struct i2c_client *client, u8 address,
@@ -278,8 +278,7 @@ static int sbs_write_word_data(struct i2c_client *client, u8 address, 
	retries = chip->i2c_retry_count;



	while (retries > 0) {

		ret = i2c_smbus_write_word_data(client, address,

			le16_to_cpu(value));

		ret = i2c_smbus_write_word_data(client, address, value);

		if (ret >= 0)

			break;

		retries--;