Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a14ef24b authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

w1: fix for loop exit condition in w1_seq_show() 



The W1_42_FINISHED_BYTE is 0xFF so the cast means the condition is
never true.

Fixes: d9411e57 ('w1: Add support for DS28EA00 sequence to w1-therm')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fc368ea1

drivers/w1/slaves/w1_therm.c

+1 −1
Original line number Diff line number Diff line
@@ -378,7 +378,7 @@ static ssize_t w1_seq_show(struct device *device, 
		w1_write_8(sl->master, W1_42_COND_READ);

		rv = w1_read_block(sl->master, (u8 *)&rn, 8);

		reg_num = (struct w1_reg_num *) &rn;

		if ((char)reg_num->family == W1_42_FINISHED_BYTE)

		if (reg_num->family == W1_42_FINISHED_BYTE)

			break;

		if (sl->reg_num.id == reg_num->id)

			seq = i;