Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a00a5fad authored by Lydia Wang's avatar Lydia Wang Committed by Takashi Iwai
Browse files

ALSA: hda - Fix creations of playback volume controls in patch_via.c 



Fix a issue to create playback volume control if pin has amplifier capability
but not DAC.

Signed-off-by: default avatarLydia Wang <lydiawang@viatech.com.cn>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 8e3679dc

sound/pci/hda/patch_via.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1631,7 +1631,7 @@ static int create_ch_ctls(struct hda_codec *codec, const char *pfx, 
	if (nid) {

	if (nid) {

		sprintf(name, "%s Playback Volume", pfx);

		sprintf(name, "%s Playback Volume", pfx);

		err = via_add_control(spec, VIA_CTL_WIDGET_VOL, name,

		err = via_add_control(spec, VIA_CTL_WIDGET_VOL, name,

			      HDA_COMPOSE_AMP_VAL(dac, chs, 0, HDA_OUTPUT));

			      HDA_COMPOSE_AMP_VAL(nid, chs, 0, HDA_OUTPUT));

		if (err < 0)

		if (err < 0)

			return err;

			return err;

	}

	}