Commit a009d29e authored Apr 01, 2010 by Wolfram Sang Committed by Anton Vorontsov Apr 06, 2010

ds2782_battery: Fix clientdata on removal

Probably due to a copy & paste bug, clientdata was set again to the data
structure (which is freed immediately afterwards) when it should be
NULLed. Just remove the calls as the i2c-core does this automatically
now.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Ryan Mallon <ryan@bluewatersys.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>

parent db217dec

drivers/power/ds2782_battery.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -236,8 +236,6 @@ static int ds2782_battery_remove(struct i2c_client *client)
		idr_remove(&battery_id, info->id);
		mutex_unlock(&battery_lock);

		i2c_set_clientdata(client, info);

		kfree(info);
		return 0;
		}
		@@ -289,7 +287,6 @@ static int ds2782_battery_probe(struct i2c_client *client,
		fail_register:
		kfree(info->battery.name);
		fail_name:
		i2c_set_clientdata(client, info);
		kfree(info);
		fail_info:
		mutex_lock(&battery_lock);