Commit 9fcf2b3c authored Jun 17, 2018 by Stefan Agner Committed by Boris Brezillon Jun 17, 2018

drm/atmel-hlcdc: check stride values in the first plane



The statement always evaluates to true since the struct fields
are arrays. This has shown up as a warning when compiling with
clang:
  warning: address of array 'desc->layout.xstride' will always
      evaluate to 'true' [-Wpointer-bool-conversion]

Check for values in the first plane instead.

Fixes: 1a396789 ("drm: add Atmel HLCDC Display Controller support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180617084826.31885-1-stefan@agner.ch

parent c7d6d511

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -875,7 +875,7 @@ static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane,
		drm_object_attach_property(&plane->base.base,
		props->alpha, 255);

		if (desc->layout.xstride && desc->layout.pstride) {
		if (desc->layout.xstride[0] && desc->layout.pstride[0]) {
		int ret;

		ret = drm_plane_create_rotation_property(&plane->base,