Commit 9e4eb1ce authored May 05, 2017 by Kees Cook Committed by David S. Miller May 08, 2017

bna: Avoid reading past end of buffer



Using memcpy() from a string that is shorter than the length copied means
the destination buffer is being filled with arbitrary data from the kernel
rodata segment. Instead, use strncpy() which will fill the trailing bytes
with zeros.

This was found with the future CONFIG_FORTIFY_SOURCE feature.

Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8403debe

drivers/net/ethernet/brocade/bna/bfa_ioc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2845,7 +2845,7 @@ bfa_ioc_get_adapter_optrom_ver(struct bfa_ioc ioc, char optrom_ver)
		static void
		bfa_ioc_get_adapter_manufacturer(struct bfa_ioc ioc, char manufacturer)
		{
		memcpy(manufacturer, BFA_MFG_NAME, BFA_ADAPTER_MFG_NAME_LEN);
		strncpy(manufacturer, BFA_MFG_NAME, BFA_ADAPTER_MFG_NAME_LEN);
		}

		static void