Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e3031ee authored by Fedor Pchelkin's avatar Fedor Pchelkin Committed by Greg Kroah-Hartman
Browse files

wifi: ath9k: don't allow to overwrite ENDPOINT0 attributes 



[ Upstream commit 061b0cb9327b80d7a0f63a33e7c3e2a91a71f142 ]

A bad USB device is able to construct a service connection response
message with target endpoint being ENDPOINT0 which is reserved for
HTC_CTRL_RSVD_SVC and should not be modified to be used for any other
services.

Reject such service connection responses.

Found by Linux Verification Center (linuxtesting.org) with Syzkaller.

Fixes: fb9987d0 ("ath9k_htc: Support for AR9271 chipset.")
Reported-by: default avatar <syzbot+b68fbebe56d8362907e8@syzkaller.appspotmail.com>
Signed-off-by: default avatarFedor Pchelkin <pchelkin@ispras.ru>
Acked-by: default avatarToke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230516150427.79469-1-pchelkin@ispras.ru


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 1c4b4661

drivers/net/wireless/ath/ath9k/htc_hst.c

+7 −1
Original line number Diff line number Diff line
@@ -114,7 +114,13 @@ static void htc_process_conn_rsp(struct htc_target *target, 


	if (svc_rspmsg->status == HTC_SERVICE_SUCCESS) {

		epid = svc_rspmsg->endpoint_id;

		if (epid < 0 || epid >= ENDPOINT_MAX)



		/* Check that the received epid for the endpoint to attach

		 * a new service is valid. ENDPOINT0 can't be used here as it

		 * is already reserved for HTC_CTRL_RSVD_SVC service and thus

		 * should not be modified.

		 */

		if (epid <= ENDPOINT0 || epid >= ENDPOINT_MAX)

			return;



		service_id = be16_to_cpu(svc_rspmsg->service_id);