Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b8e3ec3 authored by Yong Li's avatar Yong Li Committed by Linus Walleij
Browse files

gpio: pca953x: Use correct u16 value for register word write 



The current implementation only uses the first byte in val,
the second byte is always 0. Change it to use cpu_to_le16
to write the two bytes into the register

Cc: stable@vger.kernel.org
Signed-off-by: default avatarYong Li <sdliyong@gmail.com>
Reviewed-by: default avatarPhil Reid <preid@electromag.com.au>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 159f3cd9

drivers/gpio/gpio-pca953x.c

+2 −1
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
#include <linux/i2c.h>

#include <linux/platform_data/pca953x.h>

#include <linux/slab.h>

#include <asm/unaligned.h>

#include <linux/of_platform.h>

#include <linux/acpi.h>
@@ -159,7 +160,7 @@ static int pca953x_write_regs(struct pca953x_chip *chip, int reg, u8 *val) 
		switch (chip->chip_type) {

		case PCA953X_TYPE:

			ret = i2c_smbus_write_word_data(chip->client,

							reg << 1, (u16) *val);

			    reg << 1, cpu_to_le16(get_unaligned((u16 *)val)));

			break;

		case PCA957X_TYPE:

			ret = i2c_smbus_write_byte_data(chip->client, reg << 1,