Commit 9aa17a77 authored Jun 28, 2017 by Lorenzo Pieralisi Committed by Bjorn Helgaas Jun 28, 2017

PCI: faraday: Fix host bridge memory leakage



When probing the PCI host controller driver, if an error occurs, the probe
function code does not free memory allocated for the struct pci_host_bridge
resulting in memory leakage.

Move the struct pci_host_bridge allocation over to the respective devm
interface to fix the issue.

Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>

parent 5c3f18cc

drivers/pci/host/pci-ftpci100.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -448,7 +448,7 @@ static int faraday_pci_probe(struct platform_device *pdev)
	u32 val;		u32 val;
	LIST_HEAD(res);		LIST_HEAD(res);

	host = pci_alloc_host_bridge(sizeof(*p));		host = devm_pci_alloc_host_bridge(dev, sizeof(*p));
	if (!host)		if (!host)
	return -ENOMEM;		return -ENOMEM;