Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9980c620 authored by Roel Kluin's avatar Roel Kluin Committed by Takashi Iwai
Browse files

ALSA: test off by one in setsamplerate() 



With `while (i++ < MAX_WRITE_RETRY)' i reaches MAX_WRITE_RETRY + 1 after the loop

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent dfb12eeb

sound/pci/riptide/riptide.c

+1 −1
Original line number Diff line number Diff line
@@ -1058,7 +1058,7 @@ setsamplerate(struct cmdif *cif, unsigned char *intdec, unsigned int rate) 
				 rptr.retwords[2] != M &&

				 rptr.retwords[3] != N &&

				 i++ < MAX_WRITE_RETRY);

			if (i == MAX_WRITE_RETRY) {

			if (i > MAX_WRITE_RETRY) {

				snd_printdd("sent samplerate %d: %d failed\n",

					    *intdec, rate);

				return -EIO;