Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 94ef7ecb authored by Dave Martin's avatar Dave Martin Committed by Will Deacon
Browse files

arm64: fpsimd: Correctly annotate exception helpers called from asm 



A couple of FPSIMD exception handling functions that are called
from entry.S are currently not annotated as such.

This is not a big deal since asmlinkage does nothing on arm/arm64,
but fixing the annotations is more consistent and may help avoid
future surprises.

This patch adds appropriate asmlinkage annotations for
do_fpsimd_acc() and do_fpsimd_exc().

Reviewed-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Signed-off-by: default avatarDave Martin <Dave.Martin@arm.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent 27e64b4b

arch/arm64/kernel/fpsimd.c

+3 −2
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ 
#include <linux/cpu.h>

#include <linux/cpu_pm.h>

#include <linux/kernel.h>

#include <linux/linkage.h>

#include <linux/init.h>

#include <linux/percpu.h>

#include <linux/preempt.h>
@@ -102,7 +103,7 @@ static DEFINE_PER_CPU(struct fpsimd_state *, fpsimd_last_state); 
/*

 * Trapped FP/ASIMD access.

 */

void do_fpsimd_acc(unsigned int esr, struct pt_regs *regs)

asmlinkage void do_fpsimd_acc(unsigned int esr, struct pt_regs *regs)

{

	/* TODO: implement lazy context saving/restoring */

	WARN_ON(1);
@@ -111,7 +112,7 @@ void do_fpsimd_acc(unsigned int esr, struct pt_regs *regs) 
/*

 * Raise a SIGFPE for the current process.

 */

void do_fpsimd_exc(unsigned int esr, struct pt_regs *regs)

asmlinkage void do_fpsimd_exc(unsigned int esr, struct pt_regs *regs)

{

	siginfo_t info;

	unsigned int si_code = 0;