Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 949bed2f authored by Chen Gang's avatar Chen Gang Committed by Linus Torvalds
Browse files

include: mman: use bool instead of int for the return value of arch_validate_prot 

For pure bool function's return value, bool is a little better more or
less than int.

Link: http://lkml.kernel.org/r/1469331815-2026-1-git-send-email-chengang@emindsoft.com.cn


Signed-off-by: default avatarChen Gang <gang.chen.5i5j@gmail.com>
Acked-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent bd804ba1

arch/powerpc/include/asm/mman.h

+4 −4
Original line number Diff line number Diff line
@@ -31,13 +31,13 @@ static inline pgprot_t arch_vm_get_page_prot(unsigned long vm_flags) 
}

#define arch_vm_get_page_prot(vm_flags) arch_vm_get_page_prot(vm_flags)



static inline int arch_validate_prot(unsigned long prot)

static inline bool arch_validate_prot(unsigned long prot)

{

	if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_SAO))

		return 0;

		return false;

	if ((prot & PROT_SAO) && !cpu_has_feature(CPU_FTR_SAO))

		return 0;

	return 1;

		return false;

	return true;

}

#define arch_validate_prot(prot) arch_validate_prot(prot)

include/linux/mman.h

+1 −1
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ static inline void vm_unacct_memory(long pages) 
 *

 * Returns true if the prot flags are valid

 */

static inline int arch_validate_prot(unsigned long prot)

static inline bool arch_validate_prot(unsigned long prot)

{

	return (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM)) == 0;

}