Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 92d34538 authored by Amit Shah's avatar Amit Shah Committed by Rusty Russell
Browse files

virtio: console: fix raising SIGIO after port unplug 



SIGIO should be sent when a port gets unplugged.  It should only be sent
to prcesses that have the port opened, and have asked for SIGIO to be
delivered.  We were clearing out guest_connected before calling
send_sigio_to_port(), resulting in a sigio not getting sent to
processes.

Fix by setting guest_connected to false after invoking the sigio
function.

CC: <stable@vger.kernel.org>
Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent ea3768b4

drivers/char/virtio_console.c

+5 −3
Original line number Original line Diff line number Diff line
@@ -1551,12 +1551,14 @@ static void unplug_port(struct port *port) 
	spin_unlock_irq(&port->portdev->ports_lock);

	spin_unlock_irq(&port->portdev->ports_lock);





	if (port->guest_connected) {

	if (port->guest_connected) {

		/* Let the app know the port is going down. */

		send_sigio_to_port(port);



		/* Do this after sigio is actually sent */

		port->guest_connected = false;

		port->guest_connected = false;

		port->host_connected = false;

		port->host_connected = false;

		wake_up_interruptible(&port->waitqueue);





		/* Let the app know the port is going down. */

		wake_up_interruptible(&port->waitqueue);

		send_sigio_to_port(port);

	}

	}





	if (is_console_port(port)) {

	if (is_console_port(port)) {