Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f1975e3 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

inetpeer: speed up inetpeer_invalidate_tree() 



As measured in my prior patch ("sch_netem: faster rb tree removal"),
rbtree_postorder_for_each_entry_safe() is nice looking but much slower
than using rb_next() directly, except when tree is small enough
to fit in CPU caches (then the cost is the same)

From: Eric Dumazet <edumazet@google.com>

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a2e4a219

net/ipv4/inetpeer.c

+7 −4
Original line number Diff line number Diff line
@@ -284,14 +284,17 @@ EXPORT_SYMBOL(inet_peer_xrlim_allow); 


void inetpeer_invalidate_tree(struct inet_peer_base *base)

{

	struct inet_peer *p, *n;

	struct rb_node *p = rb_first(&base->rb_root);



	rbtree_postorder_for_each_entry_safe(p, n, &base->rb_root, rb_node) {

		inet_putpeer(p);

	while (p) {

		struct inet_peer *peer = rb_entry(p, struct inet_peer, rb_node);



		p = rb_next(p);

		rb_erase(&peer->rb_node, &base->rb_root);

		inet_putpeer(peer);

		cond_resched();

	}



	base->rb_root = RB_ROOT;

	base->total = 0;

}

EXPORT_SYMBOL(inetpeer_invalidate_tree);