Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8cf699ec authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

mlx4: do not call napi_schedule() without care 



Disable BH around the call to napi_schedule() to avoid following warning

[   52.095499] NOHZ: local_softirq_pending 08
[   52.421291] NOHZ: local_softirq_pending 08
[   52.608313] NOHZ: local_softirq_pending 08

Fixes: 8d59de8f ("net/mlx4_en: Process all completions in RX rings after port goes up")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Erez Shitrit <erezsh@mellanox.com>
Cc: Eugenia Emantayev <eugenia@mellanox.com>
Cc: Tariq Toukan <tariqt@mellanox.com>
Acked-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 50719195

drivers/net/ethernet/mellanox/mlx4/en_netdev.c

+4 −1
Original line number Diff line number Diff line
@@ -1748,8 +1748,11 @@ int mlx4_en_start_port(struct net_device *dev) 
	/* Process all completions if exist to prevent

	 * the queues freezing if they are full

	 */

	for (i = 0; i < priv->rx_ring_num; i++)

	for (i = 0; i < priv->rx_ring_num; i++) {

		local_bh_disable();

		napi_schedule(&priv->rx_cq[i]->napi);

		local_bh_enable();

	}



	netif_tx_start_all_queues(dev);

	netif_device_attach(dev);