Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c42cf75 authored by Wei Yongjun's avatar Wei Yongjun Committed by Tomi Valkeinen
Browse files

neofb: fix error return code in neofb_probe() 



Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent a2a6fc5f

drivers/video/neofb.c

+3 −1
Original line number Diff line number Diff line
@@ -2075,6 +2075,7 @@ static int neofb_probe(struct pci_dev *dev, const struct pci_device_id *id) 
	if (!fb_find_mode(&info->var, info, mode_option, NULL, 0,

			info->monspecs.modedb, 16)) {

		printk(KERN_ERR "neofb: Unable to find usable video mode.\n");

		err = -EINVAL;

		goto err_map_video;

	}
@@ -2097,7 +2098,8 @@ static int neofb_probe(struct pci_dev *dev, const struct pci_device_id *id) 
	       info->fix.smem_len >> 10, info->var.xres,

	       info->var.yres, h_sync / 1000, h_sync % 1000, v_sync);



	if (fb_alloc_cmap(&info->cmap, 256, 0) < 0)

	err = fb_alloc_cmap(&info->cmap, 256, 0);

	if (err < 0)

		goto err_map_video;



	err = register_framebuffer(info);