Commit 7fa2c703 authored Jan 31, 2017 by Colin Ian King Committed by Cyrille Pitchen Feb 10, 2017

mtd: spi-nor: cqspi: remove redundant dead code on error return check



Checking for ret < 0 is redundant because a previous check on ret
being non-zero already handles the ret < 0 case. Remove the redundant
code. Found by CoverityScan, CID#1398863, CID#1398864

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Richard Weinberger <richard@nod.at>
Acked-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>

parent 35fd7661

drivers/mtd/spi-nor/cadence-quadspi.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -893,7 +893,7 @@ static ssize_t cqspi_write(struct spi_nor *nor, loff_t to,
		if (ret)
		return ret;

		return (ret < 0) ? ret : len;
		return len;
		}

		static ssize_t cqspi_read(struct spi_nor *nor, loff_t from,
		@@ -913,7 +913,7 @@ static ssize_t cqspi_read(struct spi_nor *nor, loff_t from,
		if (ret)
		return ret;

		return (ret < 0) ? ret : len;
		return len;
		}

		static int cqspi_erase(struct spi_nor *nor, loff_t offs)