Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7e91a210 authored by Edward Cree's avatar Edward Cree Committed by David S. Miller
Browse files

sfc: nicer log message on Siena SR-IOV probe fail 



We expect that MC_CMD_SRIOV will fail if the card has no VFs configured.
So output a readable message instead of a cryptic MCDI error.

Signed-off-by: default avatarEdward Cree <ecree@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0bc4c070

drivers/net/ethernet/sfc/siena_sriov.c

+5 −3
Original line number Diff line number Diff line
@@ -208,7 +208,7 @@ static int efx_siena_sriov_cmd(struct efx_nic *efx, bool enable, 
	MCDI_SET_DWORD(inbuf, SRIOV_IN_VI_BASE, EFX_VI_BASE);

	MCDI_SET_DWORD(inbuf, SRIOV_IN_VF_COUNT, efx->vf_count);



	rc = efx_mcdi_rpc(efx, MC_CMD_SRIOV, inbuf, MC_CMD_SRIOV_IN_LEN,

	rc = efx_mcdi_rpc_quiet(efx, MC_CMD_SRIOV, inbuf, MC_CMD_SRIOV_IN_LEN,

				outbuf, MC_CMD_SRIOV_OUT_LEN, &outlen);

	if (rc)

		return rc;
@@ -1058,8 +1058,10 @@ void efx_siena_sriov_probe(struct efx_nic *efx) 
	if (!max_vfs)

		return;



	if (efx_siena_sriov_cmd(efx, false, &efx->vi_scale, &count))

	if (efx_siena_sriov_cmd(efx, false, &efx->vi_scale, &count)) {

		netif_info(efx, probe, efx->net_dev, "no SR-IOV VFs probed\n");

		return;

	}

	if (count > 0 && count > max_vfs)

		count = max_vfs;