Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cbb6f23 authored by Loic Poulain's avatar Loic Poulain Committed by Greg Kroah-Hartman
Browse files

net: qrtr: Fix port ID for control messages 



[ Upstream commit ae068f561baa003d260475c3e441ca454b186726 ]

The port ID for control messages was uncorrectly set with broadcast
node ID value, causing message to be dropped on remote side since
not passing packet filtering (cb->dst_port != QRTR_PORT_CTRL).

Fixes: d27e77a3 ("net: qrtr: Reset the node and port ID of broadcast messages")
Signed-off-by: default avatarLoic Poulain <loic.poulain@linaro.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 0761d31d

net/qrtr/qrtr.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -194,7 +194,7 @@ static int qrtr_node_enqueue(struct qrtr_node *node, struct sk_buff *skb, 
	hdr->src_port_id = cpu_to_le32(from->sq_port);

	hdr->src_port_id = cpu_to_le32(from->sq_port);

	if (to->sq_port == QRTR_PORT_CTRL) {

	if (to->sq_port == QRTR_PORT_CTRL) {

		hdr->dst_node_id = cpu_to_le32(node->nid);

		hdr->dst_node_id = cpu_to_le32(node->nid);

		hdr->dst_port_id = cpu_to_le32(QRTR_NODE_BCAST);

		hdr->dst_port_id = cpu_to_le32(QRTR_PORT_CTRL);

	} else {

	} else {

		hdr->dst_node_id = cpu_to_le32(to->sq_node);

		hdr->dst_node_id = cpu_to_le32(to->sq_node);

		hdr->dst_port_id = cpu_to_le32(to->sq_port);

		hdr->dst_port_id = cpu_to_le32(to->sq_port);