Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c099773 authored by Zhouyang Jia's avatar Zhouyang Jia Committed by David S. Miller
Browse files

net: cxgb3: add error handling for sysfs_create_group 



When sysfs_create_group fails, the lack of error-handling code may
cause unexpected results.

This patch adds error-handling code after calling sysfs_create_group.

Signed-off-by: default avatarZhouyang Jia <jiazhouyang09@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c14a0246

drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c

+7 −0
Original line number Diff line number Diff line
@@ -3362,10 +3362,17 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) 


	err = sysfs_create_group(&adapter->port[0]->dev.kobj,

				 &cxgb3_attr_group);

	if (err) {

		dev_err(&pdev->dev, "cannot create sysfs group\n");

		goto out_close_led;

	}



	print_port_info(adapter, ai);

	return 0;



out_close_led:

	t3_set_reg_field(adapter, A_T3DBG_GPIO_EN, F_GPIO0_OUT_VAL, 0);



out_free_dev:

	iounmap(adapter->regs);

	for (i = ai->nports0 + ai->nports1 - 1; i >= 0; --i)