Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78c181bc authored by Wolfgang Grandegger's avatar Wolfgang Grandegger Committed by Marc Kleine-Budde
Browse files

can: c_can_pci: enable PCI bus master only for MSI 



Coverity complains that c_can_pci_probe() calls pci_enable_msi() without
checking the result:

CID 712278 (#1 of 1): Unchecked return value (CHECKED_RETURN) 3. check_return:
Calling pci_enable_msi_block without checking return value (as is done
elsewhere 88 out of 105 times).
 88        pci_enable_msi(pdev);

This is CID 712278.

Signed-off-by: default avatarWolfgang Grandegger <wg@grandegger.com>
Reported-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent f323d7a1

drivers/net/can/c_can/c_can_pci.c

+5 −2
Original line number Diff line number Diff line
@@ -84,8 +84,11 @@ static int c_can_pci_probe(struct pci_dev *pdev, 
		goto out_disable_device;

	}



	ret = pci_enable_msi(pdev);

	if (!ret) {

		dev_info(&pdev->dev, "MSI enabled\n");

		pci_set_master(pdev);

	pci_enable_msi(pdev);

	}



	addr = pci_iomap(pdev, 0, pci_resource_len(pdev, 0));

	if (!addr) {