Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76da0704 authored by WANG Cong's avatar WANG Cong Committed by David S. Miller
Browse files

ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER 



In commit 242d3a49 ("ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf")
I assumed NETDEV_REGISTER and NETDEV_UNREGISTER are paired,
unfortunately, as reported by jeffy, netdev_wait_allrefs()
could rebroadcast NETDEV_UNREGISTER event until all refs are
gone.

We have to add an additional check to avoid this corner case.
For netdev_wait_allrefs() dev->reg_state is NETREG_UNREGISTERED,
for dev_change_net_namespace(), dev->reg_state is
NETREG_REGISTERED. So check for dev->reg_state != NETREG_UNREGISTERED.

Fixes: 242d3a49 ("ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf")
Reported-by: default avatarjeffy <jeffy.chen@rock-chips.com>
Cc: David Ahern <dsahern@gmail.com>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Acked-by: default avatarDavid Ahern <dsahern@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b866203d

net/ipv6/route.c

+5 −1
Original line number Diff line number Diff line
@@ -3722,7 +3722,11 @@ static int ip6_route_dev_notify(struct notifier_block *this, 
		net->ipv6.ip6_blk_hole_entry->dst.dev = dev;

		net->ipv6.ip6_blk_hole_entry->rt6i_idev = in6_dev_get(dev);

#endif

	 } else if (event == NETDEV_UNREGISTER) {

	 } else if (event == NETDEV_UNREGISTER &&

		    dev->reg_state != NETREG_UNREGISTERED) {

		/* NETDEV_UNREGISTER could be fired for multiple times by

		 * netdev_wait_allrefs(). Make sure we only call this once.

		 */

		in6_dev_put(net->ipv6.ip6_null_entry->rt6i_idev);

#ifdef CONFIG_IPV6_MULTIPLE_TABLES

		in6_dev_put(net->ipv6.ip6_prohibit_entry->rt6i_idev);