Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 73a6839f authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Samuel Ortiz
Browse files

mfd: ezx-pcap: Remvove open coded irq handling 



There is no point in checking irq_desc here, as it _is_ available. The
driver configured those lines, so they cannot go away.

The home brewn disabled/note_interrupt magic can be removed as well by
adding a irq_disable callback which avoids the lazy disable.

That driver needs to be converted to threaded interrupts.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 256d0e2e

drivers/mfd/ezx-pcap.c

+3 −11
Original line number Diff line number Diff line
@@ -162,6 +162,7 @@ static void pcap_unmask_irq(struct irq_data *d) 


static struct irq_chip pcap_irq_chip = {

	.name		= "pcap",

	.irq_disable	= pcap_mask_irq,

	.irq_mask	= pcap_mask_irq,

	.irq_unmask	= pcap_unmask_irq,

};
@@ -196,17 +197,8 @@ static void pcap_isr_work(struct work_struct *work) 
		local_irq_disable();

		service = isr & ~msr;

		for (irq = pcap->irq_base; service; service >>= 1, irq++) {

			if (service & 1) {

				struct irq_desc *desc = irq_to_desc(irq);



				if (WARN(!desc, "Invalid PCAP IRQ %d\n", irq))

					break;



				if (desc->status & IRQ_DISABLED)

					note_interrupt(irq, desc, IRQ_NONE);

				else

					desc->handle_irq(irq, desc);

			}

			if (service & 1)

				generic_handle_irq(irq);

		}

		local_irq_enable();

		ezx_pcap_write(pcap, PCAP_REG_MSR, pcap->msr);