Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 719ca811 authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

bnxt_en: Fix "uninitialized variable" bug in TPA code path. 



In the TPA GRO code path, initialize the tcp_opt_len variable to 0 so
that it will be correct for packets without TCP timestamps.  The bug
caused the SKB fields to be incorrectly set up for packets without
TCP timestamps, leading to these packets being rejected by the stack.

Reported-by: default avatarAndy Gospodarek <andrew.gospodarek@broadocm.com>
Acked-by: default avatarAndy Gospodarek <andrew.gospodarek@broadocm.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cd33b3e0

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+1 −1
Original line number Diff line number Diff line
@@ -1099,7 +1099,7 @@ static struct sk_buff *bnxt_gro_func_5730x(struct bnxt_tpa_info *tpa_info, 
{

#ifdef CONFIG_INET

	struct tcphdr *th;

	int len, nw_off, tcp_opt_len;

	int len, nw_off, tcp_opt_len = 0;



	if (tcp_ts)

		tcp_opt_len = 12;