Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 704936a2 authored by Luiz Fernando Capitulino's avatar Luiz Fernando Capitulino Committed by Greg Kroah-Hartman
Browse files

[PATCH] usbserial: Fixes use-after-free in serial_open(). 



If the device is disconnected while serial_open() is executing and
either try_module_get() or the device specific open function fails, the
kref_put() call in the 'bailout_kref_put' label will free the memory
pointed out by 'port'.

The subsequent dereferences in the 'bailout_kref_put' label will be
invalid.

The fix is just to assure kref_put() is called after any 'port' usage.

Signed-off-by: default avatarLuiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 16c23f7d

drivers/usb/serial/usb-serial.c

+1 −1
Original line number Diff line number Diff line
@@ -225,9 +225,9 @@ static int serial_open (struct tty_struct *tty, struct file * filp) 
bailout_module_put:

	module_put(serial->type->driver.owner);

bailout_kref_put:

	kref_put(&serial->kref, destroy_serial);

	port->open_count = 0;

	mutex_unlock(&port->mutex);

	kref_put(&serial->kref, destroy_serial);

	return retval;

}