Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f5cdfa8 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Bjorn Helgaas
Browse files

PCI: Prevent sysfs disable of device while driver is attached 



Manipulating the enable_cnt behind the back of the driver will wreak
complete havoc with the kernel state, so disallow it.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Acked-by: default avatarKeith Busch <keith.busch@intel.com>
parent 17e8f0d4

drivers/pci/pci-sysfs.c

+9 −6
Original line number Diff line number Diff line
@@ -288,13 +288,16 @@ static ssize_t enable_store(struct device *dev, struct device_attribute *attr, 
	if (!capable(CAP_SYS_ADMIN))

		return -EPERM;



	if (!val) {

		if (pci_is_enabled(pdev))

	device_lock(dev);

	if (dev->driver)

		result = -EBUSY;

	else if (val)

		result = pci_enable_device(pdev);

	else if (pci_is_enabled(pdev))

		pci_disable_device(pdev);

	else

		result = -EIO;

	} else

		result = pci_enable_device(pdev);

	device_unlock(dev);



	return result < 0 ? result : count;

}