Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6bf6ded3 authored by Andrzej Hajda's avatar Andrzej Hajda Committed by Sebastian Reichel
Browse files

HSI: omap_ssi: fix handling ida_simple_get result 

The function can return negative value.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576



Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent 403c5c06

drivers/hsi/controllers/omap_ssi.c

+3 −4
Original line number Diff line number Diff line
@@ -323,11 +323,10 @@ static int __init ssi_add_controller(struct hsi_controller *ssi, 
		return -ENOMEM;

	}



	ssi->id = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL);

	if (ssi->id < 0) {

		err = ssi->id;

	err = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL);

	if (err < 0)

		goto out_err;

	}

	ssi->id = err;



	ssi->owner = THIS_MODULE;

	ssi->device.parent = &pd->dev;