Commit 687b0ad2 authored Jan 06, 2014 by Kent Overstreet Committed by Tejun Heo Jan 21, 2014

percpu-refcount: Add a WARN() for ref going negative



AIO had a missing get, which led to an ioctx leak - after percpu_ref_kill() the
ref was 0 so percpu_ref_put() never saw it hit 0.

This wasn't noticed at the time because it all happened completely silently,
this adds a WARN() which would've caught the aio bug.

tj: Used WARN_ONCE() instead of WARN().

Signed-off-by: Kent Overstreet <kmo@daterainc.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent 6ce4eac1

lib/percpu-refcount.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -120,6 +120,9 @@ static void percpu_ref_kill_rcu(struct rcu_head *rcu)

		atomic_add((int) count - PCPU_COUNT_BIAS, &ref->count);

		WARN_ONCE(atomic_read(&ref->count) <= 0, "percpu ref <= 0 (%i)",
		atomic_read(&ref->count));

		/* @ref is viewed as dead on all CPUs, send out kill confirmation */
		if (ref->confirm_kill)
		ref->confirm_kill(ref);