Commit 62e3436b authored May 26, 2010 by Arnaldo Carvalho de Melo

perf tui: Reset use_browser if stdout is not a tty

The newt initialization routines weren't being called because the output
was a file (perf annotate > /tmp/bla) but use_browser was still 1,
because ~/.perfconfig had it as 'on', so, later on newt routines
segfaulted.

Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 49c17746

tools/perf/builtin-annotate.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -343,7 +343,7 @@ static void hists__find_annotations(struct hists *self)
		continue;
		}

		if (use_browser) {
		if (use_browser > 0) {
		key = hist_entry__tui_annotate(he);
		if (is_exit_key(key))
		break;

tools/perf/util/newt.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1139,6 +1139,7 @@ void setup_browser(void)
		struct newtPercentTreeColors *c = &defaultPercentTreeColors;

		if (!isatty(1) \|\| !use_browser \|\| dump_trace) {
		use_browser = 0;
		setup_pager();
		return;
		}