Commit 60cde81f authored Mar 26, 2013 by Yuval Mintz Committed by David S. Miller Mar 27, 2013

bnx2x: Fix AER semaphore release



Commit 7fa6f340 "AER revised" erroneously inserted an error-flow
in which a semaphore is released even though the attempt to take it
has failed.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Ariel Elior <ariele@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 40893fd0

drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -10070,8 +10070,8 @@ static int bnx2x_prev_unload(struct bnx2x *bp)
		/* If Path is marked by EEH, ignore unload status */
		aer = !!(bnx2x_prev_path_get_entry(bp) &&
		bnx2x_prev_path_get_entry(bp)->aer);
		}
		up(&bnx2x_prev_sem);
		}

		if (fw == FW_MSG_CODE_DRV_UNLOAD_COMMON \|\| aer) {
		rc = bnx2x_prev_unload_common(bp);