Commit 609aaf6a authored Oct 16, 2017 by Bartosz Golaszewski Committed by Linus Walleij Oct 19, 2017

gpiolib: don't allow OPEN_DRAIN & OPEN_SOURCE flags for input

OPEN_DRAIN and OPEN_SOURCE flags only affect the way we drive a GPIO
line, so they only make sense for output mode. Just as we only allow
input mode for event handle requests, don't allow passing open-drain
and open-source flags for any other mode than explicit output.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 418ee8e9

drivers/gpio/gpiolib.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -457,6 +457,12 @@ static int linehandle_create(struct gpio_device gdev, void __user ip)
		if (lflags & ~GPIOHANDLE_REQUEST_VALID_FLAGS)
		return -EINVAL;

		/* OPEN_DRAIN and OPEN_SOURCE flags only make sense for output mode. */
		if (!(lflags & GPIOHANDLE_REQUEST_OUTPUT) &&
		((lflags & GPIOHANDLE_REQUEST_OPEN_DRAIN) \|\|
		(lflags & GPIOHANDLE_REQUEST_OPEN_SOURCE)))
		return -EINVAL;

		lh = kzalloc(sizeof(*lh), GFP_KERNEL);
		if (!lh)
		return -ENOMEM;